Forgot to merge pull request before pushing branch update #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d make.bat to use this requirement. This was done to fix the error encountered when attempting to build the Windows exe without having pillow installed.
Added pillow to requirements_to_build_windows_exe.txt file and update…
earlyraven
pushed a commit
to earlyraven/Dungeon-Cross
that referenced
this pull request
May 23, 2023
…tion and removing ambiguities. Original Treasure Chest Rules: A treasure chest is always in a 3x3 empty room with exactly ONE entrance. The chest can appear in ANY of the 3x3 tiles in that room. (Yes, a treasure chest can appear directly in the entrance) Original Ambiguity halfburnttoast#1: Counter-intuitive that a tile in the room is considered the entrance. It would be clearer to treat the empty tile orthogonally adjacent to the room as the entrance. Original Ambiguity halfburnttoast#2: Based on the previous text, it seems possible for a treasure room to contain more than one chest, but this should not be the case. Treasure rooms should only contain exactly one chest. Original Ambiguity halfburnttoast#3: Based on the current entrance definition, this might be a valid setup, but it shouldn't be (1 = entrance, 0 = empty tile, X = Wall): XXX0XXXX X001100X X000000X X000000X XXXXXXXX (two connected treasure rooms). This should not be possible though. Proposal S: Each treasure room contains a single chest in a 3x3 grid of walkable tiles and has a single entry point located orthogonally adjacent and outside the treasure room. The treasure room must be fully enclosed by walls or the map border on all orthogonally surrounding sides, except for the designated entry point, which must be an empty tile. Proposal S Notes: - Addresses Counter-intuitive entrance: Proposal S specifies that the entry point should be located orthogonally adjacent and outside the treasure room, providing a clearer definition of the entrance location. - Addresses Multiple chests in a treasure room: Proposal S explicitly states that each treasure room contains a single chest, eliminating the possibility of multiple chests within a room. - Addresses Validity of treasure room connections: Proposal S implicitly restricts the formation of connected treasure rooms by emphasizing the need for full enclosure by walls or the map border on all orthogonally surrounding sides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.