Do not add video backgrounds to speaker notes. #1037
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimel
added a commit
that referenced
this pull request
Nov 5, 2014
Do not add video backgrounds to speaker notes.
|
Thanks! |
|
Hello @hakimel, sorry to re-open the discussion, but wouldn't it be better to mute the audio? I have background-video only slides, and not showing them in the speaker notes makes the view pretty useless. To me, playing videos but muted would make much more sense. |
I was actually considering writing a bug report that videos don't show in speaker notes, but then I found this report. |
hakimel
added a commit
that referenced
this pull request
Oct 21, 2024
|
I've changed this so that background videos will play in the speaker view 95946b4 |
|
You're on fire, thanks! |
gbastkowski
pushed a commit
to gbastkowski/reveal.js
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add video backgrounds in speaker notes window as per issue #1036