add babel runtime as a dependencies, optimize for complex folder structure #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PippoRaimondi
requested changes
Nov 23, 2020
There was a problem hiding this comment.
I need to write a checklist for contributors, meanwhile can you at least provide the following:
- Reason of the change in the description
- Add unit tests if possible, if not confirm the feature is covered by the e2e test (it seems if we add a e2e test with a complex folder structure should be enough to validate the changes)
- In order to trigger a new version/release your commit message (at least one of the commits) needs to follow a particular pattern. for example for a new feature right:
feature: optimise for complex file structure
|
ok, i'll add test later |
|
@ssddi456 Any update on your PR? Can you finalize it? |
@mehrad-rafigh I will finalise it now! |
|
I am accepting this PR and will add a test in a separate one.. I've validated the change and it looks good! @mehrad-rafigh version 1.7.1 contains complex folder structure handling! |
|
🎉 This PR is included in version 1.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.