-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[batch/auth] Set accounts to "inactive" after extended inactivity #14789
Open
grohli
wants to merge
24
commits into
hail-is:main
Choose a base branch
from
grohli:disable-inactive-accounts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive' table in case we want to avoid changing the users table schema.
I don't have the batch context to review this thoroughly, but I do have some high level questions:
|
cjllanwarne
requested changes
Jan 14, 2025
Responding to @patrick-schultz -
|
…n SQL; renamed last_active to last_activated; updated associated DB migration SQL.
…/hail into disable-inactive-accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Addressing compliance requirement wherein Hail accounts must be disabled/marked as inactive after a certain number of days of inactivity. This is accomplished as follows (pending PR revisions):
last_activated
column has been added to theusers
table, used for storing a given user's last active timestamp;last_activated
timestamp is updated to the current date/time;last_activated
timestamp is more than 60 days old (configurable and will default to 60 unless specified otherwise); andactive
if it's currentlyinactive
while also updating the user'slast_activated
field toCURRENT_TIMESTAMP(3)
.Security Assessment
Impact Description
This change entails a change to the
users
table schema and additional authorization-related checks thereof, but none of this is exposed to users and all happens internally.(Reviewers: please confirm the security impact before approving)