Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] unify backend rpc #14693

Closed
wants to merge 1 commit into from
Closed

[query] unify backend rpc #14693

wants to merge 1 commit into from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 18, 2024

No description provided.

@ehigham ehigham marked this pull request as ready for review September 18, 2024 20:47
@ehigham ehigham mentioned this pull request Sep 18, 2024
Merged
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 6a03bb4 to 99e06b5 Compare September 18, 2024 21:07
This was referenced Sep 19, 2024
Merged
Merged
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 99e06b5 to 9283b9c Compare September 19, 2024 20:51
@ehigham ehigham mentioned this pull request Sep 19, 2024
Merged
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 19, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ehigham ehigham mentioned this pull request Sep 19, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 40cfdd1 to 8ac34e8 Compare September 19, 2024 20:53
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 9283b9c to 7d91073 Compare September 19, 2024 20:53
ehigham
ehigham commented Sep 19, 2024
View reviewed changes
hail/python/hail/backend/py4j_backend.py

def _parse_matrix_ir(self, code):
return self._jbackend.parse_matrix_ir(code)

def _parse_blockmatrix_ir(self, code):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still used to compute blockmatrix sparsity. All others were just used in tests to test that irs parse (which is done by the _type methods)
I wonder if we can move sparsity into the block matrix type and then this too can be removed?

This was referenced Sep 20, 2024
Open
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 8ac34e8 to 956e751 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f2c39a6 to 2f3f122 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 956e751 to c07ff10 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2f3f122 to b02c83b Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from c07ff10 to e7782e2 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from b02c83b to 20e6520 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from e7782e2 to 7969e05 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 20e6520 to e66b858 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 7969e05 to 1142a0d Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from e66b858 to 49bdf73 Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 1142a0d to cf4fa39 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 49bdf73 to 0ce4a09 Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from d0ed52f to ed249ec Compare January 21, 2025 16:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 88a3844 to 749d5fa Compare January 21, 2025 16:48
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from ed249ec to b60c6de Compare January 21, 2025 20:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 749d5fa to 73eaa93 Compare January 21, 2025 20:15
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from b60c6de to fc4df24 Compare January 21, 2025 21:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 73eaa93 to 220a71a Compare January 21, 2025 21:02
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from fc4df24 to ec29acc Compare January 22, 2025 15:50
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 220a71a to bbbea4f Compare January 22, 2025 15:50
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from ec29acc to 9aecc1d Compare January 22, 2025 16:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from bbbea4f to db27b14 Compare January 22, 2025 16:46
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9aecc1d to 234a058 Compare January 22, 2025 17:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch 2 times, most recently from 3eae5a8 to 5712e62 Compare January 22, 2025 21:13
@ehigham ehigham changed the base branch from ehigham/ctx-persisted-ir to ehigham/ctx-coercer-cache January 22, 2025 21:13
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 5712e62 to 23f6536 Compare January 24, 2025 20:35
@ehigham ehigham changed the base branch from ehigham/ctx-coercer-cache to ehigham/move-gen-into-tests January 24, 2025 20:35
@ehigham ehigham mentioned this pull request Jan 24, 2025
Open
1 task
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from b6a31f7 to fc08ea1 Compare January 24, 2025 20:54
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 23f6536 to 796a644 Compare January 24, 2025 20:55
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from fc08ea1 to 97dd229 Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 796a644 to 7c34e3e Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 97dd229 to db88046 Compare January 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 7c34e3e to f6d9e15 Compare January 29, 2025 20:23
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from db88046 to 1ff37b2 Compare January 29, 2025 20:40
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f6d9e15 to cee1574 Compare January 29, 2025 20:40
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 1ff37b2 to 174743e Compare January 29, 2025 21:41
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cee1574 to 904e13b Compare January 29, 2025 21:41
@ehigham ehigham closed this Jan 29, 2025
@ehigham ehigham deleted the ehigham/http-like-rpc branch January 29, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehigham