Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vds/combiner] Fix truncation of PL in GVCF import with haploid calls #14577

Conversation

chrisvittal
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a test

@hail-ci-robot hail-ci-robot merged commit 63db10a into hail-is:main Jun 17, 2024
2 checks passed
chrisvittal added a commit that referenced this pull request Jul 30, 2024
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [vds/combiner] Fix truncation of PL in GVCF import with haploid calls (#14577)
chrisvittal added a commit that referenced this pull request Jul 30, 2024
This patch version implements necessary changes for working with Variant
Datasets with haploid calls, as well as one critical correctness bug,
the substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [vds/combiner] Fix truncation of PL in GVCF import with haploid calls (#14577)
chrisvittal added a commit that referenced this pull request Jul 30, 2024
This patch version implements necessary changes for working with Variant
Datasets with haploid calls. The substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [vds/combiner] Fix truncation of PL in GVCF import with haploid calls (#14577)
chrisvittal added a commit that referenced this pull request Aug 7, 2024
This patch version implements necessary changes for working with Variant
Datasets with haploid calls. The substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [vds/combiner] Fix truncation of PL in GVCF import with haploid calls (#14577)
chrisvittal added a commit that referenced this pull request Aug 8, 2024
This patch version implements necessary changes for working with Variant
Datasets with haploid calls. The substantial backports are:

   - [vds/combiner] Stop dropping GT in reference data during gvcf import (#14560)
   - [vds/combiner] Fix truncation of PL in GVCF import with haploid calls (#14577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants