Add better handling for large numbers in is.integerish #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be simpler to do |
|
@hadley good suggestion, I've implemented it. Had never heard of |
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage ? 73.25%
=========================================
Files ? 9
Lines ? 86
Branches ? 0
=========================================
Hits ? 63
Misses ? 23
Partials ? 0
Continue to review full report at Codecov.
|
hadley
reviewed
Jun 26, 2018
| is.integer(x) || (is.numeric(x) && all(x == as.integer(x))) | ||
|
|
||
| # using trunc() to deal with very large numbers (including Inf) | ||
| res <- is.integer(x) || (is.numeric(x) && all(x == trunc(x))) |
There was a problem hiding this comment.
Can you please eliminate the explicit return? See http://style.tidyverse.org/functions.html#return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses concerns raised in #42 and #44 . Basically,
is.integerishencounters NAs when you try to apply it over values that are larger thanbase::.Machine$integer.max. In this PR, I just added explicit handling for that condition to throw a more informative error message.