Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy upgrade #1091

Merged
merged 2 commits into from
Oct 11, 2024
Merged

numpy upgrade #1091

merged 2 commits into from
Oct 11, 2024

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Oct 11, 2024 •
edited
Loading

Summary of the Pull Request

  • upgrades numpy to 2*
  • solves a tie-breaking issue: when the score is equal the pandas sorting in libinteractive was giving inconsistent results (depending on the architecture). Adding an additional, unambiguous field (the caprieval_rank) to the sorting solves the issue.

Related Issue

Closes #1092

@mgiulini mgiulini mentioned this pull request Oct 11, 2024
Closed
@mgiulini mgiulini self-assigned this Oct 11, 2024
@mgiulini mgiulini marked this pull request as ready for review October 11, 2024 15:12
@mgiulini mgiulini requested a review from rvhonorato October 11, 2024 15:12
rvhonorato
rvhonorato approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@mgiulini mgiulini merged commit 2ec9a8b into main Oct 11, 2024
4 checks passed
@mgiulini mgiulini deleted the np2-upgrade branch October 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvhonorato rvhonorato rvhonorato approved these changes

Assignees

@mgiulini mgiulini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update numpy to version 2*
2 participants
@mgiulini @rvhonorato