Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround plotly / kaleido static figure generation #1086

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Workaround plotly / kaleido static figure generation #1086

merged 5 commits into from
Oct 10, 2024

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Oct 9, 2024 •
edited
Loading

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

  • Removed the kaleido package for mandatory packages
  • Added kaleidoas optional package
  • Do not generate matrix plots (in [clustfcc] and [clustrmsd]) when over 3100 entries (3100 * 3100 points).
  • Added uni-tests for the generation of plots performed by haddock3-analyse --format png
  • Added checks in haddock3-analyse when --format option is specified to make sure kaleido is installed.

Related Issue

Closes #1089

@VGPReys VGPReys self-assigned this Oct 9, 2024
@VGPReys VGPReys added the enhancement Enhancing an existing feature of adding a new one label Oct 9, 2024
@VGPReys VGPReys requested a review from mgiulini October 9, 2024 13:08
@VGPReys VGPReys changed the title managing cluster plots Workaround plotly / kaleido static figure generation Oct 9, 2024
@rvhonorato rvhonorato enabled auto-merge October 10, 2024 12:43
@rvhonorato rvhonorato merged commit 7ee7cd3 into main Oct 10, 2024
4 checks passed
@rvhonorato rvhonorato deleted the fix-length-tests branch October 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvhonorato rvhonorato rvhonorato approved these changes

@mgiulini mgiulini Awaiting requested review from mgiulini

Assignees

@VGPReys VGPReys

Labels
enhancement Enhancing an existing feature of adding a new one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uni-tests taking for ever
2 participants
@VGPReys @rvhonorato