-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rolling submission #100
Rolling submission #100
Conversation
Implement GetJobID and CheckSlurmStatus functions Add tests for GetJobID function Implement WaitFor function Refactor UpdateStatus function Implement Clean and Post functions
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
This PR leverages go's concurrency with a semaphore pattern to control the flow of job submissions. It adds a
job.WaitUntil
method that runsj.UpdateStatus
to pass the status up and move to the execution of a next job.In summary its a "rolling-submission" approach, that new jobs are submitted as soon as the old ones match the expected status. This is controlled by the
max_concurrent
parameter.One important note here is that the SLURM status and the
haddock-runner
status are not the same! Thej.UpdateStatus
method handles this translation.