Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling submission #100

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

rvhonorato
Copy link
Member

@rvhonorato rvhonorato commented Jan 30, 2024

This PR leverages go's concurrency with a semaphore pattern to control the flow of job submissions. It adds a job.WaitUntil method that runs j.UpdateStatus to pass the status up and move to the execution of a next job.

In summary its a "rolling-submission" approach, that new jobs are submitted as soon as the old ones match the expected status. This is controlled by the max_concurrent parameter.

One important note here is that the SLURM status and the haddock-runner status are not the same! The j.UpdateStatus method handles this translation.

@rvhonorato rvhonorato linked an issue Jan 30, 2024 that may be closed by this pull request
Copy link

codacy-production bot commented Jan 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (87ca2d9) 1213 1213 100.00%
Head commit (8fe8aab) 1323 (+110) 1323 (+110) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#100) 115 115 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@rvhonorato rvhonorato self-assigned this Jan 30, 2024
@rvhonorato rvhonorato added the feature New feature or request label Jan 30, 2024
@rvhonorato rvhonorato marked this pull request as ready for review January 30, 2024 15:22
@rvhonorato rvhonorato changed the title Submit payload in batches when posting to slurm Rolling submission Jan 30, 2024
@rvhonorato rvhonorato merged commit c744482 into main Jan 30, 2024
6 checks passed
@rvhonorato rvhonorato deleted the 98-submit-payload-in-batches-when-posting-to-slurm branch January 30, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit payload in batches when posting to SLURM
1 participant