Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for templates load #147

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

phansys
Copy link
Member

@phansys phansys commented Aug 20, 2019

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Requirement for "knplabs/knp-paginator-bundle" was updated from ^2.3 to ^2.6, since versions previous to v2.6.0 were using the service "templating.helper.router", which is not registered within the current dependencies.

phansys added a commit that referenced this pull request Aug 20, 2019
This PR was merged into the master branch.

Discussion
----------

|Q            |A     |
|---          |---   |
|Branch       |master|
|Bug fix?     |no    |
|New feature? |no    |
|BC breaks?   |no    |
|Deprecations?|no    |
|Tests pass?  |yes   |
|Fixed tickets|n/a   |
|License      |MIT   |
|Doc PR       |n/a   |

Requirement for "knplabs/knp-paginator-bundle" was updated [from `^2.3` to `^2.6`](KnpLabs/KnpPaginatorBundle@v2.3.2...v2.6.0#diff-0a26006f70eb61548221c2dd5b0c15f2L40), since versions previous to `v2.6.0` were using the service "templating.helper.router", which is not registered within the current dependencies.

Commits
-------

7e196f3 Add tests for templates load
@phansys phansys merged commit 7e196f3 into hackzilla-project:master Aug 20, 2019
@phansys phansys deleted the twig_tests branch August 20, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants