Inconsistent Image Locations

[averdin2]

Overview

We need to audit the images in our folder and update to the correct path so that our images have a consistent path with where these files are located.

Action Items

• Go through the following folders and check if there are any files that are seemingly misplaced or need to be removed.
  • assets/images
  • _includes/svg
• Remove or relocate files that are not in the right location.
  • If you remove or relocate files, make sure to check other files where these files may be referenced and update their location.

Resources/Instructions

This is the image folder:
https://github.com/hackforla/website/tree/gh-pages/assets/images

Some things to consider:

• I believe that the hero folder and toolkit-default-card-image.png file are the primary places to check for this issue. When checking the other folders, just make sure that the files logically make sense to be in those folders. For example, if you are looking at the about folder, just make sure images that have to do with communities of practice aren't in that folder.
• If you think there are files that could or should be moved to another folder, feel free to propose a new location for these files.
• I suspect that some changes regarding this issue may need a team discussion, so feel free to bring this issue up during meetings and message the slack channel if you need help making decisions for this issue.

[Aveline-art]

Following comments on #1909 , we need to decide where to place assets that are not bound by one single location (for example, one file is replicated/reused in multiple pages). The next step might be to perform a thorough audit of the website's assets to assess:

1. Which assets are currently being used.
2. Which assets are only used once.
3. Which assets are used multiple times.
4. Decide what to do with each asset (delete? relocate?)

[ExperimentsInHonesty]

This issue needs to be rewritten.
Create a Spreadsheet (what is the info we need to collect? e.g. Name of image, current location, page(s) it appears on, proposed location, etc.)
List every image that appears on the website
Fill out the sheet for that image
...

[github-actions]

Hi @jefflueck, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[jefflueck]

I would like to pick up this issue but saw that it needed to be rewritten a couple of days ago by @ExperimentsInHonesty.
Can it be picked up now or should I wait? @jefflueck

[github-actions]

Hi @jefflueck, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[jefflueck]

Availability: Monday, Wednesday, Friday 12:00 am - 6:00 pm CST
ETA: EOD Sunday 4/16/23

[jefflueck]

In our meeting on 4/16/2023 it was decided to make a spreadsheet according to @ExperimentsInHonesty comment before moving any files or deleting image locations for review.

Spreadsheet to be created in team google drive.

Availability: Friday 5:00 pm - 9:00 pm CST
ETA: EOD Sunday 4/23/2023

[jefflueck]

Progress: Audited through about half of the images folders, and added to the audit spreadsheet for issue #1900.
Blockers: none at this time.
Availability: Thursday, Friday 12:00 pm - 6:00 pm CST | Sunday 3:00 pm - 7:00 pm CST.
ETA: Not sure due to amount of images and files to Audit.
Google Sheet:
https://docs.google.com/spreadsheets/d/1hjrkb4fpy-U37fdP8UysHuAEMPfj81YHhhmXHXy0cbk/edit?usp=sharing

[jefflueck]

Audit is finished.
No code base changes due to this being an audit only per conversation with Bonnie on a team meeting.
Please review spreadsheet as this was as far as the issue was suppose to be taken as of now.
Google Sheet:
https://docs.google.com/spreadsheets/d/1hjrkb4fpy-U37fdP8UysHuAEMPfj81YHhhmXHXy0cbk/edit?usp=sharing

[ExperimentsInHonesty]

@jefflueck I will need to help you reformat the sheet so that we can do next steps. See you at the next sunday meeting.

[jefflueck]

ETA: Wednesday Evening
Availability: Monday, Tuesday, and Wednesday 12:00 pm CST - 5:00 PM CST
Blockers: None

[jefflueck]

Finished
Ready for review.
Spreadsheet location:
https://docs.google.com/spreadsheets/d/1hjrkb4fpy-U37fdP8UysHuAEMPfj81YHhhmXHXy0cbk/edit?usp=sharing

[jefflueck]

Review needed.
The plan for 5/29/23 meeting is once the sheet is good it can be brought to the merge team so they can create several large issues to help clean up the code base from technical debt.
Finished according to last meeting on 5/29/23, ready fo
r final review before sent to merge team.
@jefflueck @ExperimentsInHonesty

[roslynwythe]

Hi @jefflueck please fill in the missing cell data. Also please explain the note "Do not suggesting moving files because of _ flag".

[jefflueck]

Finished spreadsheet. Ready for Merge Team to analyze for making into large issues.

As part of this is behind the current website deployment it will need to be looked at by possibly several members to see what needs current credits, image removal, or turned into large issues for Dev Team.

I will be removing myself as the spreadsheet data needs to be analyzed to create more issues to be worked on to get rid of technical debt or credit needed for deployment to the current website.

[github-actions]

Hi @jefflueck, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[jefflueck]

Waiting for meeting with @ExperimentsInHonesty to discuss spreadsheet for final approval of work done.
Availability: Vacation Aug 14th - 20th.
Availability: 21, 22, 23, 25 27. 10:00 - 5:00 CST

[ExperimentsInHonesty]

We need to add the SVGs to the Credits page with the following info for each sdg image yml credit file:

---
title: SDG [Replace with # and Title]
title-link: https://www.un.org/sustainabledevelopment/news/communications-material
content-type: image
used-in: [Replace with where used]
artist: unknown
provider: United Nations Dept of Global Communications
provider-link: https://www.un.org/sustainabledevelopment/news/communications-material
image-url: /assets/images/sdg/[Replace with IMAGE NAME]
alt: '[Replace with SDG # and TITLE]'
---

[ExperimentsInHonesty]

Several project in md files are marked visable: false, which means they don't show up on the website.

We need to add the following comment to the project's md files

# This project's image has no credit information.  If this project ends up back on the website, a new image will have to be created and an appropriate credit file made.

[ExperimentsInHonesty]

Project: Home Unite Us
Delete the image current called home-unite-us.png which looks like this

https://github.com/hackforla/website/blob/gh-pages/assets/images/projects/home-unite-us.png

Rename the image called home-heart.png to home-unite-us.png to be consistent with all other project card images.

https://github.com/hackforla/website/blob/gh-pages/assets/images/projects/home-heart.png

And get credit information to create a credit.yml file.

[jefflueck]

Audit and spreadsheet finished.

[jefflueck]

Roslyn White will look at the code base from about 6 months ago to see if some images have been renamed or moved. Once this is determined, we can decide what to do with the images so we do not delete an image in use.

[jefflueck]

Finished, ready to be added to Sunday's meeting.
I finished the _flag issues and now have instructions in those note sections.
This looks like the old wiki images, are being moved over to the new toolkit section of the website.
Some of these are still being worked on.
@roslynwythe

[jefflueck]

I finished with this audit.
It is now being moved to ERs to be made into large issues for Dev Team to work on.

[roslynwythe]

• See ER: duplicate GitHub icons and inconsistent locations #6903 and ER: duplicate Slack icons and inconsistent locations #7377