Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mariamawit guide infobox 1590 #2023

Merged
merged 5 commits into from
Feb 2, 2025
Merged

Conversation

mmogesdesigns
Copy link
Member

@mmogesdesigns mmogesdesigns commented Jan 9, 2025

What changes did you make?

  • Updated the tooltip functionality to work with React Tooltip v5.
  • Replaced outdated data-tip and data-for attributes with data-tooltip-id and data-tooltip-content as per v5 requirements.
  • Integrated the component directly into the EarnedPointsProgress and SidebarProjectLevel components.
  • Adjusted the tooltip hover functionality so it triggers properly.
  • Preserved the existing structure of the components while ensuring tooltip integration is consistent.

Why did you make the changes (we will use this info to test)?

  • React Tooltip was updated to v5, which caused the previous implementation (using v4 props and attributes) to break. These changes ensure the tooltips work as expected.
  • Tooltips now display the correct dynamic content from the component’s logic when hovering over the green circle or related elements.
  • The updated functionality aligns with the React Tooltip v5 API, preventing future compatibility issues.
Screenshot 2025-01-08 at 5 10 41 PM

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

The tooltip hover functionality now works as expected, but aligning the tooltip’s CSS positioning to match the original design is still a challenge. The tooltip’s place and offset props have been used to adjust positioning, but the desired alignment is not yet achieved. Additional CSS adjustments or a review of the tooltip’s parent container styles may be necessary to address this fully. It might be worth creating a new issue specifically for tooltip alignment and positioning if needed.
Visuals after changes are applied

image

@entrotech entrotech changed the title Mariamawit guide infobox 1823 Mariamawit guide infobox 1590 Jan 30, 2025
@entrotech
Copy link
Member

In the time that Miriamwit was wworking on this issue, the Designers created Issue #1997, which changed the styling and functionality of the tooltips for the Sidebar and the Target Points page such that the tooltips now need to have a close box on them. This required replacing the react-tooltlip library that Miriam just upgraded with the reactjs-popup library, to allow for the close box. This also required revisiting how the styling is done to comply with Issue #1997. While doing this, I also made the same changes to the broken "popovers" on the Target Points page as part of the adjustments to this PR.

@entrotech entrotech merged commit 7e6c2b0 into develop Feb 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Tooltips for Sidebar question icon are broken
2 participants