Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added feature flag using useFeatureFlag hook #1827

Merged

Conversation

SAUMILDHANKAR
Copy link
Member

Web screenshot before

Web screenshot after

Mobile screenshot before

Mobile screenshot after

Copy link
Member

@junjun107 junjun107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add .env.local to gitignore file.

@SAUMILDHANKAR SAUMILDHANKAR force-pushed the saumildhankar-1824-implementing-feature-flags branch from f0e8693 to 977327c Compare September 28, 2023 01:59
@SAUMILDHANKAR
Copy link
Member Author

SAUMILDHANKAR commented Sep 28, 2023

You forgot to add .env.local to gitignore file.

@junjun107 Oh no totally forgot about that. Thanks for catching the blunder. 🙏

Update1: I still see the .env.local file part of the commit. Let me update the address in the .gitignore

Update2: Removed .env.local file from the commit. Hope it is good now. Looking forward to your review.

@SAUMILDHANKAR SAUMILDHANKAR force-pushed the saumildhankar-1824-implementing-feature-flags branch 2 times, most recently from 3258ee2 to 1c6a36e Compare September 28, 2023 07:57
added env local to git ignore

updated address of .env.local file in gitignore

ignored .env.local file

added .env.local again
@SAUMILDHANKAR SAUMILDHANKAR force-pushed the saumildhankar-1824-implementing-feature-flags branch from 1c6a36e to 2208f56 Compare September 28, 2023 11:19
Copy link
Member

@junjun107 junjun107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement feature flags
2 participants