-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #1606
Merged
Merged
update dependencies #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate to material ui 5 - emotion ui was added as per mui recommendations (https://mui.com/material-ui/getting-started/installation/) - @material-ui/core, @material-ui/icons, @material-ui/lab removed - replaced with @mui/material, @mui/icons-material, @mui/lab - migrate to react router 6 - update and remove unused dev dependencies - redux-devtools-extension was deprecated in favor of @redux-devtools/extension - babel-eslint was deprecated in favor of @babel/eslint-parser - enzyme was removed as it was unused - fixed linter errors from updating eslint - many were fixed with `npm run lint:fixed` - manual fixes applied to Blog.jsx - `default-param-last`, `no-restricted-exports`, and `react/jsx-no-constructed-context-values` converted to warnings - react-day-picker was not updated due to breaking style changes
Note: `npx depcheck` incorrectly indicates `eslint-import-resolver-node` and `eslint-import-resolver-node` as unused
edwinjue
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ykaros
pushed a commit
to Ykaros/311-data
that referenced
this pull request
Nov 21, 2023
* update most dependencies to latest version, added support for node 18 * large migration commit - migrate to material ui 5 - emotion ui was added as per mui recommendations (https://mui.com/material-ui/getting-started/installation/) - @material-ui/core, @material-ui/icons, @material-ui/lab removed - replaced with @mui/material, @mui/icons-material, @mui/lab - migrate to react router 6 - update and remove unused dev dependencies - redux-devtools-extension was deprecated in favor of @redux-devtools/extension - babel-eslint was deprecated in favor of @babel/eslint-parser - enzyme was removed as it was unused - fixed linter errors from updating eslint - many were fixed with `npm run lint:fixed` - manual fixes applied to Blog.jsx - `default-param-last`, `no-restricted-exports`, and `react/jsx-no-constructed-context-values` converted to warnings - react-day-picker was not updated due to breaking style changes * update readme * remove routechange.jsx * remove date-fns * revert date fns changes * update react-markdown to latest version compatible with react 17 * remove more unused dev dependencies Note: `npx depcheck` incorrectly indicates `eslint-import-resolver-node` and `eslint-import-resolver-node` as unused * update to latest react 17 * update workflow to use node 18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really large commit but many of the changes were performed automatically by either
npm run lint:fix
or the MUI codemod (to update all Material UI imports). I've indicated the notable changes to review below (ie: The files I've manually modified)package.json
for dependency updates, notable updates belowUpdated to Node 18 (LTS/Hydrogen)
Updated to React 17 (not 18 due to incompatibilities with Material UI 5 and react-day-picker v7)
Updated Redux to v8
Updated React Router to v6
redux-devtools-extension
was deprecated in favor of@redux-devtools/extension
babel-eslint
was deprecated in favor of@babel/eslint-parser
extract-text-webpack-plugin
was deprecated in favor ofmini-css-extract-plugin
Migration to MUI 5
@material-ui/core
,@material-ui/icons
,@material-ui/lab
removed and replaced with@mui/material
,@mui/icons-material
,@mui/lab
@mui/lab
is not actually used, but I kept it in in the event we need to use a component from itVarious unused dependencies removed (identified with
npx depcheck
)Depcheck output
Note:
eslint-import-resolver-node
andeslint-import-resolver-node
are incorrectly indicated as unused and was not removedREADME.md
: Updated with updated information.eslintrc.js
: Some new linting rules were added with updates to eslint and its various plugins. I've converted a few to warnings that would have otherwise been errors with the current codebase.github/workflows/main.yml
: Update Github Action to use Node 18.gitignore
: I added .DS_Store because I use a macApp.jsx
: Routes was renamed to AppRoutes due to react-router using the name Routes, and RouteChange is no longer needed with react-router 6 so they were removedRoutes.jsx
: ThemeProvider changes for MUI 5, Name changes for react-router 6Header.jsx
: NavLink changes with react-router 6,activeStyle
was removed in favor of usingstyle
with a conditional andgetContentAnchorEl
was deprecatedBlog.jsx
: Manually resolved linter error about returning a Fragment with only 1 elementindex.js
(root): MUI 5 migration changes and URL updatestore.js
: Updated function names for@redux-devtools/extension
theme.js
: MUI 5 migration changeswebpack.config.js
,webpack.dev.js
,webpack.prod.js
: Migration to webpack 5 and removal ofsocial-tags-webpack-plugin
in favor of social tags functionality already available withhtml-webpack-plugin
and an incompatibility that I don't rememberreact-day-picker
v7 is deprecated, but I did not update it because it ended up being nontrivial and contains breaking style changesFixes #1537