Add a workshop validation route #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moosichu
approved these changes
Feb 12, 2018
| static var workshopVerifyHandler: RouterHandler = { request, response, next in | ||
| if let workshopId = request.parameters["workshopId"] { | ||
| let workshopURL = "https://github.com/hackersatcambridge/workshop-\(workshopId)" | ||
| // Pull the repo to /test/id repo |
|
Created #232 for situations where a completely incorrect git repo is accidentally provided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #222
Adds a route
/workshops/validate/:workshopIdThat parses the workshop repo at
github.com/hackersatcambridge/workshop-<workshopId>and prints results for quick validation of workshop repos.Screenshots (for frontend changes only):
Some results:
There is an issue with this in the dev environment. Trying to validate a workshop where the repo doesn't exist will cause an indefinite request and subsequent reloads of the server in the dev environment will fail due to this request still holding the port open (as far as I can tell). This is due to the Git command requesting a username which can't be given so hangs.