Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logan create edit event validation #54

Closed
wants to merge 5 commits into from

Conversation

logancostello
Copy link
Collaborator

Developer: Logan Costello

Closes #{ISSUE NUMBER HERE}

Pull Request Summary

Refactored CreateEditEvent into CreateEvent and Edit Event.
EditEvent takes event as input.
EditEvent fills in the fields from the event when opened.
Added start and end time to both components
Added volunteer event switch to both components
Added Only my group allowed switch to both components (only available when volunteer event is true. volunteer event being false makes this switch false and disabled.
Implemented validation for all fields (switches are inherently selected already, so they don't require it)

Note: the components have an event type, but the event schema does not. One of these will likely need to change in the future to accommodate each other. If this is an unintended issue, I can fix it.

Modifications

Created CreateEvent and EditEvent
Deleted CreateEditEvent

Testing Considerations

Tested manually all possibilities I could think of

Pull Request Checklist

  • Code is neat, readable, and works
  • Comments are appropriate
  • The commit messages follows our guidelines
  • The developer name is specified
  • The summary is completed
  • Assign reviewers

Screenshots/Screencast

Screen.Recording.2024-02-14.at.8.27.39.PM.mov

@logancostello logancostello linked an issue Feb 15, 2024 that may be closed by this pull request
@javalosr2004 javalosr2004 self-requested a review February 15, 2024 20:31
Copy link
Collaborator

@javalosr2004 javalosr2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Event / Modify Event Form Validation
2 participants