fix permanent-peer, no-color and verbose output cli args #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Parfitt <[email protected]>
|
By analyzing the blame information on this pull request, we identified @fnichol, @reset, @adamhjk and @kmacgugan to be potential reviewers |
bookshelfdave
changed the title
|
👍 |
|
📌 Commit 2c3855a has been approved by |
thesentinels
added a commit
that referenced
this pull request
Jun 27, 2016
fix permanent-peer, no-color and verbose output cli args
Clap args that don't take a param (`--permanent-peer`, `--no-color` and `-v`) weren't recognized with:
if sub_args.value_of("foo").is_some() {...
as they never have a value. Instead, we use
if sub_args.is_present("foo") {...
Additionally, verbose and no-color flags are marked as "global", but are registered in `sub_args` instead of `args` in `fn config_from_args`. I removed `args` as we aren't using that struct any more.
cc @thommay
|
☀️ Test successful - travis |
christophermaier
added
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clap args that don't take a param (
--permanent-peer,--no-colorand-v) weren't recognized with:as they never have a value. Instead, we use
Additionally, verbose and no-color flags are marked as "global", but are registered in
sub_argsinstead ofargsinfn config_from_args. I removedargsas we aren't using that struct any more.cc @thommay