Use best practices in artifactory-pro run hook #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These updates are based on feedback from @jamesc in habitat-sh#989. Signed-off-by: Seth Chisamore <[email protected]>
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
Thank you! |
|
📌 Commit bb3152b has been approved by |
thesentinels
added a commit
that referenced
this pull request
Jun 27, 2016
Use best practices in artifactory-pro run hook These updates are based on feedback from @jamesc in #989. Signed-off-by: Seth Chisamore <[email protected]> /cc @smith
|
☀️ Test successful - travis |
|
Built and uploaded to depot: https://app.habitat.sh/#/pkgs/core/artifactory-pro/4.8.1/20160628172056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are based on feedback from @jamesc in #989.
Signed-off-by: Seth Chisamore [email protected]
/cc @smith