Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[builder-web] Make it so clicking outside the user-nav dropdown makes… #985

Merged
merged 1 commit into from
Jun 28, 2016
Merged

[builder-web] Make it so clicking outside the user-nav dropdown makes… #985

merged 1 commit into from
Jun 28, 2016

Conversation

smith
Copy link
Contributor

@smith smith commented Jun 24, 2016

… it go away

gif-keyboard-4426270991134005478

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @ryankeairns and @metadave to be potential reviewers

@ryankeairns
Copy link
Contributor

@thesentinels r+

2 similar comments
@bookshelfdave
Copy link
Contributor

@thesentinels r+

@bookshelfdave
Copy link
Contributor

@thesentinels r+

@thesentinels
Copy link
Contributor

📌 Commit 83520fd has been approved by metadave

@thesentinels
Copy link
Contributor

⌛ Testing commit 83520fd with merge 89a24b5...

thesentinels added a commit that referenced this pull request Jun 28, 2016
@thesentinels
Auto merge of #985 - habitat-sh:nls/dropdown-toggle, r=metadave
89a24b5 
[builder-web] Make it so clicking outside the user-nav dropdown makes…

… it go away

![gif-keyboard-4426270991134005478](https://cloud.githubusercontent.com/assets/9912/16328063/c3ea2b78-399b-11e6-829e-93b26a47bac4.gif)
@thesentinels
Copy link
Contributor

☀️ Test successful - travis

@thesentinels thesentinels merged commit 83520fd into master Jun 28, 2016
@fnichol fnichol deleted the nls/dropdown-toggle branch July 8, 2016 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smith @thesentinels @ryankeairns @bookshelfdave @adamhjk