[hab] Make the install.sh script more portable with BusyBox userland.
#982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to make the gzip'd tarball extraction more portable in non-GNU userlands by first using `zcat` and then piping the stream to `tar` for extraction. This change allows for a better out-of-the-box experience in minimal distributions such as the BusyBox Docker image, Alpine Linux, etc. Signed-off-by: Fletcher Nichol <[email protected]>
|
By analyzing the blame information on this pull request, we identified @schisamo to be a potential reviewer |
|
|
|
📌 Commit afe0bfe has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 24, 2016
This change aims to make the gzip'd tarball extraction more portable in non-GNU userlands by first using `zcat` and then piping the stream to `tar` for extraction. This change allows for a better out-of-the-box experience in minimal distributions such as the BusyBox Docker image, Alpine Linux, etc. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #982 Approved by: smith
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to make the gzip'd tarball extraction more portable in
non-GNU userlands by first using
zcatand then piping the stream totarfor extraction. This change allows for a better out-of-the-boxexperience in minimal distributions such as the BusyBox Docker image,
Alpine Linux, etc.
Thanks to @bscott for debugging with me!