Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the LOG format #1036

Closed
ryankeairns opened this issue Jul 5, 2016 · 4 comments · Fixed by #1699
Closed

Document the LOG format #1036

ryankeairns opened this issue Jul 5, 2016 · 4 comments · Fixed by #1699
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Milestone

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Jul 5, 2016

Based up conversation in #1012 , the consensus was that the two-letter LOGKEY format was unclear. Options discussed included expanding the LOGKEY format and/or providing clear documentation on the acronym definitions.

@reset
Copy link
Collaborator

reset commented Jul 5, 2016

I dropped a comment in that thread but I'll repost it so we can continue the discussion here:

The purpose of the two character log key isn't for informing users, but developer access and debugging. We are supposed to be using these to identify which module a log even is coming from without needing to specify the full path plus crate name of the module in the log output. This is much like the way we log error messages in the servers with a very similar format.

I would stick with two or three character log prefixes, expanding them is going to clutter the log and I don't think it makes things any easier to track down.

@ryankeairns
Copy link
Contributor Author

Sounds good - seems like we just need to document this somewhere logical for people to decipher the messages (if we haven't already).

@adamhjk
Copy link
Contributor

adamhjk commented Jul 6, 2016

Lets document it and keep it to two characters. They are troubleshooting keys, and the expanded version doesn't make that better - it makes it worse. :)

@adamhjk
Copy link
Contributor

adamhjk commented Jul 6, 2016

Just in case I wasn't clear here - the two character thing has a good reason. It walks the line between crazy verbose logging with specific modules and line numbers, and the ability to determine where in the code base the log line comes from. Two characters is short enough to not be intrusive, and makes the output much easier to parse when we're trying to understand what it means.

So this PR should become "document the log format", not "change the behavior" - because the behavior is good.

@ryankeairns ryankeairns changed the title Change LOGKEY format/behavior Document the LOG format Jul 6, 2016
@bscott bscott self-assigned this Jul 14, 2016
@smurawski smurawski added this to the Help Wanted milestone Dec 6, 2016
smith pushed a commit that referenced this issue Feb 1, 2017
Closes #1036.

Signed-off-by: Nathan L Smith <[email protected]>
smith pushed a commit that referenced this issue Feb 1, 2017
Closes #1036.

Signed-off-by: Nathan L Smith <[email protected]>
@christophermaier christophermaier added the Documentation Flags an issue / PR for attention by the technical documentation team label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants