[PR Feedback] Renamed 'timestamp' proto field to 'occurred_at'

Signed-off-by: Christopher Maier <[email protected]>

components/sup/protocols/event.proto

@@ -9,8 +9,7 @@ message EventMetadata {
   string supervisor_id = 1;
   // The IP address on which the Supervisor is listening for gossip.
   string ip_address = 2;
-  // The time at which this event occurred.
-  google.protobuf.Timestamp timestamp = 3;
+  google.protobuf.Timestamp occurred_at = 3;
   string application = 4;
   string environment = 5;
   map<string, string> meta = 6;

components/sup/src/event.rs

@@ -217,7 +217,7 @@ fn publish(mut event: impl EventMessage) {
         // one.
         //
         // The ugliness is at least contained, though.
-        event.event_metadata(EventMetadata { timestamp:
+        event.event_metadata(EventMetadata { occurred_at:
                                                  Some(std::time::SystemTime::now().into()),
                                              ..EVENT_CORE.get::<EventCore>().to_event_metadata() });
 

components/sup/src/event/types.rs

@@ -69,11 +69,12 @@ impl Service {
 impl EventCore {
     /// Create a protobuf metadata struct for all event messages.
     pub(super) fn to_event_metadata(&self) -> EventMetadata {
+        // occurred_at will be set to Some when the event is published.
         EventMetadata { supervisor_id: self.supervisor_id.clone(),
                         ip_address:    self.ip_address.to_string(),
                         application:   self.application.clone(),
                         environment:   self.environment.clone(),
-                        timestamp:     None,
+                        occurred_at:   None,
                         meta:          self.meta.clone().into(), }
     }
 }