[tomcat8] fix world access permissions #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chetan, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jtimberman to be a potential reviewer |
Signed-off-by: Chetan Sarva <[email protected]>
chetan
force-pushed
the
fix_tomcat8_perms
branch
2 times, most recently
from
8808658 to
7f2543e
Compare
|
@jtimberman any thoughts on this one? |
|
I've actually got some more commits coming, based on discussions in slack. Should fix a few more issues.. |
Signed-off-by: Chetan Sarva <[email protected]>
chetan
force-pushed
the
fix_tomcat8_perms
branch
from
ff5a65d to
d3da063
Compare
|
@chetan drop a note here when you've finished with your additional commits 😄 |
|
@reset the last push was it. good to go |
|
core/tomcat8/8.5.4/20160824210409 has been built and uploaded to the depot. 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default permissions included in the tarball don't give any world access. This is now a problem with the fixed svc_user/group in hab 0.9.0 (habitat-sh/habitat#1012)