Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@h6s/website): revert bump react18 #224

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Conversation

SoYoung210
Copy link
Member

@SoYoung210 SoYoung210 commented Nov 29, 2022

@JaeYeopHan i missed #223 branch deploy of "h6s.dev" was canceled. sorry 🙏

- facebook/docusaurus#7264
- docusaurus does not support react18 yet
@height
Copy link

height bot commented Nov 29, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for h6s-react-examples failed.

Name Link
🔨 Latest commit a6b6d4c
🔍 Latest deploy log https://app.netlify.com/sites/h6s-react-examples/deploys/6385bec9af39e80009fa6b85

@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for h6s-dev canceled.

Name Link
🔨 Latest commit a6b6d4c
🔍 Latest deploy log https://app.netlify.com/sites/h6s-dev/deploys/6385bec9677e1d000978a1df

@netlify
Copy link

netlify bot commented Nov 29, 2022

Deploy Preview for storybook-h6s ready!

Name Link
🔨 Latest commit a6b6d4c
🔍 Latest deploy log https://app.netlify.com/sites/storybook-h6s/deploys/6385bec92ac9320009fcd59a
😎 Deploy Preview https://deploy-preview-224--storybook-h6s.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SoYoung210
Copy link
Member Author

SoYoung210 commented Nov 29, 2022

image

check example/react result..

next-dev.js?95dc:20 Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17

i'll reopen pr after resolve above issue → Clear!

image

@SoYoung210 SoYoung210 closed this Nov 29, 2022
@SoYoung210 SoYoung210 reopened this Nov 29, 2022
@SoYoung210 SoYoung210 merged commit 68485da into main Nov 29, 2022
@SoYoung210 SoYoung210 deleted the revert/website-react-version branch November 29, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant