Skip to content

Commit

Permalink
Replay 1f18bdb due to incorrect merge conflict resolution in 94ff7b3
Browse files Browse the repository at this point in the history
  • Loading branch information
figureone committed May 25, 2018
1 parent e1af0c1 commit 9d612b7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
11 changes: 3 additions & 8 deletions scripts/html5.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,13 +188,7 @@ H5P.VideoHtml5 = (function ($) {
}

if (arg === H5P.Video.PLAYING) {
if (self.seeking === true) {
extraArg = self.videoXAPI.getArgsXAPISeeked(self.seekedTo);
extraTrigger = 'seeked';
lastSend = 'seeked';
self.seeking = false;
}
else if (lastSend !== 'play') {
if (lastSend !== 'play') {
extraArg = self.videoXAPI.getArgsXAPIPlayed(video.currentTime);
extraTrigger = 'play';
lastSend = 'play';
Expand All @@ -203,7 +197,7 @@ H5P.VideoHtml5 = (function ($) {

if (arg === H5P.Video.PAUSED) {
// Put together extraArg for sending to xAPI statement.
if (!video.seeking && self.seeking === false && video.currentTime !== video.duration) {
if (!video.seeking && self.seeking === false && video.currentTime !== video.duration && self.previousState !== H5P.Video.BUFFERING) {
extraTrigger = 'paused';
extraArg = self.videoXAPI.getArgsXAPIPaused(video.currentTime, video.duration);
lastSend = 'paused';
Expand Down Expand Up @@ -300,6 +294,7 @@ H5P.VideoHtml5 = (function ($) {
arg = self.getPlaybackRate();
break;
}
self.previousState = arg;
self.trigger(h5p, arg);

// Make extra calls for events with needed values for xAPI statement.
Expand Down
7 changes: 2 additions & 5 deletions scripts/youtube.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,10 @@ H5P.VideoYouTube = (function ($) {
if (self.seeking === false) {
self.trigger('play', self.videoXAPI.getArgsXAPIPlayed(player.getCurrentTime()));
}
else {
self.trigger('seeked', self.videoXAPI.getArgsXAPISeeked(self.seekedTo));
self.seeking = false;
}
}
else if (state.data === 2) {
// This is a paused event.
if (self.seeking === false) {
if (self.seeking === false && self.previousState !== 3) {
self.trigger('paused', self.videoXAPI.getArgsXAPIPaused(player.getCurrentTime(), self.duration));
}
}
Expand All @@ -147,6 +143,7 @@ H5P.VideoYouTube = (function ($) {
}
}
}
self.previousState = state.data;
},
onPlaybackQualityChange: function (quality) {
self.trigger('qualityChange', quality.data);
Expand Down

0 comments on commit 9d612b7

Please sign in to comment.