Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server conf files #188

Merged
merged 10 commits into from
Jan 3, 2020
Merged

Server conf files #188

merged 10 commits into from
Jan 3, 2020

Conversation

LeoColomb
Copy link
Member

@LeoColomb LeoColomb commented May 6, 2019 •
edited
Loading

Closes #1
Closes #72
Closes #139

To-Do:

@LeoColomb LeoColomb added this to the v4.0.0 milestone May 6, 2019
@LeoColomb LeoColomb requested a review from XhmikosR May 6, 2019 01:37
@XhmikosR
Copy link
Member

XhmikosR commented May 6, 2019

Not sure if I can review this later, but IMO we should release a 3.2.0 from the current changes, assuming we don't have breaking ones merged already.

@LeoColomb
Copy link
Member Author

we should release a 3.2.0

Indeed, see #189.

Not sure if I can review this later

What do you mean?

@LeoColomb LeoColomb force-pushed the feat/conf-repo branch 5 times, most recently from 1435729 to 8b73d11 Compare May 9, 2019 00:08
@LeoColomb LeoColomb mentioned this pull request May 9, 2019
Closed
@LeoColomb
Copy link
Member Author

Updated to reduce future noise: everything required for server config is here (tests/examples/documentation).

#168 has been merged into this PR.

Only one commit alter .htaccess content: 88d56f1, moving PROTO env variable definition where it's actually used.
Behavior is not altered.

@XhmikosR Let me now if you can review that one, if so take your time, no stress! 😄

@Malvoz You're welcomed to review too! 🙂

@LeoColomb LeoColomb force-pushed the feat/conf-repo branch 4 times, most recently from 1a0b1fa to d26a011 Compare May 15, 2019 16:11
@LeoColomb
Copy link
Member Author

Friendly bump 🙂

@Malvoz
Copy link
Contributor

Malvoz commented Jul 11, 2019

Just a quick catch on:

Later in another PR:

Cleanup (remove redondant parts like #153, #185)

Remove #185 from #188 (comment), per h5bp/server-configs-nginx@bc39e4c

@LeoColomb LeoColomb mentioned this pull request Aug 7, 2019
Merged
@LeoColomb LeoColomb force-pushed the feat/conf-repo branch 2 times, most recently from d61764f to c2f8811 Compare August 7, 2019 23:45
@LeoColomb
Copy link
Member Author

@XhmikosR Are you available for a review? Thx! 😇

@XhmikosR
Copy link
Member

Sorry, I don't have a lot of time to spend on this repo. Maybe before proceeding with merging this see if a new release should be made from the changes so far 3.2.1...master

@LeoColomb
Copy link
Member Author

No problem, just let me know. 🙂
We can release a new version before merging, for sure.

@LeoColomb LeoColomb merged commit c302596 into master Jan 3, 2020
@LeoColomb LeoColomb deleted the feat/conf-repo branch January 3, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR Awaiting requested review from XhmikosR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0.0
3 participants
@LeoColomb @XhmikosR @Malvoz