Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery CDN docs - remove unnecessary info #2122

Merged
merged 2 commits into from
Mar 19, 2019
Merged

jQuery CDN docs - remove unnecessary info #2122

merged 2 commits into from
Mar 19, 2019

Conversation

coliff
Copy link
Member

@coliff coliff commented Mar 18, 2019

I propose to remove this paragraph:

The jQuery CDN version was chosen over other potential candidates
(like Google's Hosted Libraries)
because it's fast (comparable or faster than Google by some
measures
)
and, (unlike Google's CDN) is available to China's hundreds of millions of internet users.
For many years we chose
the Google Hosted version over the jQuery CDN because it was available
over HTTPS (the jQuery CDN was not,) and it offered a better chance of
hitting the cache lottery owing to the popularity of the Google CDN.
The first issue is no longer valid and the second is far outweighed by
being able to serve jQuery to Chinese users.

We switched to jQuery CDN a long while ago and don't feel that providing this information is too useful. If you disagree and would rather keep it then instead we should just change this PR to change the last sentence to read '...serve jQuery to users in China' (rather than ...serve jQuery to Chinese users)

@coliff coliff requested a review from roblarsen March 18, 2019 01:04
@coliff coliff changed the title remove unnessecary info jQuery CDN docs - remove unnecessary info Mar 18, 2019
@roblarsen
Copy link
Member

@coliff I would prefer to leave the detail in here, just based on the amount of time it took to make the decision. It took forever.

"users in china" is better language, however.

@coliff
Copy link
Member Author

coliff commented Mar 19, 2019

cool - no prob. I've updated this PR as suggested.

@roblarsen roblarsen merged commit b846ed9 into master Mar 19, 2019
@coliff coliff deleted the jquery-cdn branch March 20, 2019 03:55
@coliff coliff mentioned this pull request Jun 3, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants