sampling-based tracing through Unix sockets #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clock, to avoid the hassle of having callbacks called at arbitrary moments to obtain SNI of a non-ptls socket
…d code elimination)
kazuho
added a commit
to h2o/quicly
that referenced
this pull request
Dec 2, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the support for sampling-based tracing through Unix sockets.
Connections to be traced can be selected based on the combination of the following criteria:
floatbetween 0 and 1Unlike the old USDT-based scheme (as has been provided by h2olog), the new interface allows each logger to specify different criteria. Up to 32 loggers are supported.
As we transition from using USDT to Unix sockets, sampling support is removed from the USDT side. Otherwise, USDT probes are retained as-is, as they are considered valuable properties when debugging the system as a whole with picotls or h2o being part of the system.