Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXIF Orientation - Incorrect rotation based on EXIF #284

Closed
vposham opened this issue Jan 3, 2020 · 1 comment
Closed

EXIF Orientation - Incorrect rotation based on EXIF #284

vposham opened this issue Jan 3, 2020 · 1 comment
Assignees

Comments

@vposham
Copy link

vposham commented Jan 3, 2020

Hi all,

First of all, thanks for this awesome service.

I think I found an image rotation issue, exif based rotation is not working as expected in case of EXIF values - 2,4, 5 and 7.

Below URLs should all result in the same image, as I'm setting stripmeta to true and norotation to false(default behaviour).

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_0.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_1.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_2.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_3.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_4.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_5.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_6.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_7.jpg&stripmeta=true

http://localhost:9000/resize?width=300&height=200&url=https://github.com/recurser/exif-orientation-examples/raw/master/Landscape_8.jpg&stripmeta=true

However, responses from Images 2,4,5,7 results in 180 rotated images or flip-flopped images. Please correct me if I missed anything here.

@h2non h2non self-assigned this Jun 7, 2020
h2non added a commit that referenced this issue Jun 7, 2020
h2non added a commit that referenced this issue Jun 7, 2020
* feat: add fly.io

* feat(readme): fly image width

* feat(readme): add html image + badge

* fix(docs): try space non-URL encoding

* Update README.md

* Update README.md

* Update README.md

* feat(docs): add fly.io info and links

* feat(#305, #309, #308, #305. #284)

* fix(ci): golinter

* fix(Dockerfile): use root folder for go test / ci linter

* fix(ci): allow to fail  go 1.14 build, still not sure why

* fix(ci): bad yaml format

* fix(ci): use travis-compatible regex

* fix(ci): lets skip go1.14 for now

* fix(mod): update dependencies
@h2non
Copy link
Owner

h2non commented Jun 7, 2020

Fixed in v1.2.0. Closing.

@h2non h2non closed this as completed Jun 7, 2020
j-keck pushed a commit to artidis/imaginary that referenced this issue Aug 11, 2022
* feat: add fly.io

* feat(readme): fly image width

* feat(readme): add html image + badge

* fix(docs): try space non-URL encoding

* Update README.md

* Update README.md

* Update README.md

* feat(docs): add fly.io info and links

* feat(h2non#305, h2non#309, h2non#308, h2non#305. h2non#284)

* fix(ci): golinter

* fix(Dockerfile): use root folder for go test / ci linter

* fix(ci): allow to fail  go 1.14 build, still not sure why

* fix(ci): bad yaml format

* fix(ci): use travis-compatible regex

* fix(ci): lets skip go1.14 for now

* fix(mod): update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants