Improve construction of unit nodes

- use proper curies - skip UMUC until biopragmatics/bioregistry#648 is resolved - add dual labels
gyorilab · Nov 15, 2022 · 9370099 · 9370099
1 parent 2a525f6
commit 9370099
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/mira/dkg/construct.py b/mira/dkg/construct.py
@@ -244,10 +244,11 @@ def main(add_xref_edges: bool, summaries: bool, do_upload: bool):
 
     click.secho("Units", fg="green", bold=True)
     for wikidata_id, label, description, xrefs in tqdm(get_unit_terms(), unit="unit"):
-        node_sources[term.id].add("wikidata")
-        nodes[term.id] = NodeInfo(
-            curie=f"wikidata:{wikidata_id}",
-            prefix="wikidata",
+        curie = f"wikidata:{wikidata_id}"
+        node_sources[curie].add("wikidata")
+        nodes[curie] = NodeInfo(
+            curie=curie,
+            prefix="wikidata;unit",
             label=label,
             synonyms="",
             deprecated="false",

diff --git a/mira/dkg/units.py b/mira/dkg/units.py
@@ -43,7 +43,10 @@ def get_unit_terms():
     rv = []
     for record in records:
         xrefs = []
-        for prefix in ["umuc", "qudt"]:
+        for prefix in [
+            # "umuc",
+            "qudt",
+        ]:
             value = record.get(prefix)
             if value:
                 xrefs.append(f"{prefix}:{value['value']}")