Be more generic, for Rc and Arc to replace &.
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Physical Device is Copy.
|
Just noticed this PR. @gwihlidal This contains changes I made in my own fork that are specific to my application. I'm using my own fork of the underlying VulkanMemoryAllocator and that might not be a good idea to be merged into the master branch. Those changes just aren't ready to be upstreamed yet. I would recommend to rollback and do some actual code reviews. @cheako You should've pinged me in the PR as it contains changes I made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't useful for me, perhaps it'll be useful for some?