Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Angular 14 #469

Closed
stijnvn opened this issue Jun 14, 2022 · 7 comments
Closed

Support for Angular 14 #469

stijnvn opened this issue Jun 14, 2022 · 7 comments
Labels
released on @next released

Comments

@stijnvn
Copy link

stijnvn commented Jun 14, 2022

Can you update ng-dynamic-component to support Angular 14?
@gund
Copy link
Owner

gund commented Jun 14, 2022

Yes, however the current version should also work just fine with angular v14. Did you try to use it?

@stijnvn
Copy link
Author

stijnvn commented Jun 14, 2022

I have got an npm error that it was not compatible with Angular 14.

@gund
Copy link
Owner

gund commented Jun 14, 2022

Oh could you please post it here if possible?

@stijnvn
Copy link
Author

stijnvn commented Jun 15, 2022

I guess you should just update the dependency on Angular

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^12.0.0 || ^13.0.0" from [email protected]
npm ERR! node_modules/ng-dynamic-component
npm ERR!   ng-dynamic-component@"10.1.0" from the root project

gund added a commit that referenced this issue Jun 15, 2022
@gund
feat(ng): add support for Angular v14+
a3fa92a 
Now library allows Angular v12+ as a peer dependency hence there are no breacking changes

fix #469
gund pushed a commit that referenced this issue Jun 15, 2022
@semantic-release-bot
chore(release): release 10.2.0-next.1 [skip ci]
a3faccb 
# [10.2.0-next.1](v10.1.0...v10.2.0-next.1) (2022-06-15)

### Features

* **ng:** add support for Angular v14+ ([451f04e](451f04e)), closes [#469](#469)
@gund
Copy link
Owner

gund commented Jun 15, 2022

🎉 This issue has been resolved in version 10.2.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund
Copy link
Owner

gund commented Jun 15, 2022 •
edited
Loading

@stijnvn could you please try to install version 10.2.0-next.2 and see if the problem is solved?
Once it's confirmed I will release it as latest.

@gund gund closed this as completed in 451f04e Jun 16, 2022
gund pushed a commit that referenced this issue Jun 16, 2022
@semantic-release-bot
chore(release): release 10.2.0 [skip ci]
6697cd4 
# [10.2.0](v10.1.0...v10.2.0) (2022-06-16)

### Bug Fixes

* **component:** add compatibility with Angular v12 to component rendering ([18c3922](18c3922)), closes [#472](#472)

### Features

* **ng:** add support for Angular v14+ ([451f04e](451f04e)), closes [#469](#469)
@gund
Copy link
Owner

gund commented Jun 16, 2022

🎉 This issue has been resolved in version 10.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gund @stijnvn