Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 12 support #454

Closed
TokkeDev opened this issue May 25, 2021 · 11 comments
Closed

Angular 12 support #454

TokkeDev opened this issue May 25, 2021 · 11 comments
Labels

Comments

@TokkeDev
Copy link

With the release of Angular 12, it'd be lovely to see official support from ng-dynamic-component 👌

@gund
Copy link
Owner

gund commented May 25, 2021

Sure, the update will come soon.

Out of curiosity - does the latest version still work with Angular v12?

@TokkeDev
Copy link
Author

TokkeDev commented Jul 6, 2021

Sorry for the late reply, @gund. Yes, everything seems to be working just fine as of Angular 12.1.1 👌

@edbzn
Copy link

edbzn commented Aug 1, 2021

Hi @gound, any plan to support Angular 12 in the near future? We are depending on ng-dynamic-component in our package @jscutlery/cypress-mount and this causes an issue with Angular 12 due to the outdated peer deps:

  "peerDependencies": {
    "@angular/common": "^11.0.0",
    "@angular/core": "^11.0.0",
    "rxjs": "^6.0.0"
  },

@TheCelavi
Copy link

Hello, is there any reason why there is no activity for this issue? Do you need a PR which would bump dependencies?

@edbzn
Copy link

edbzn commented Oct 5, 2021

We are planning to fork this project to overcome this.

@TheCelavi
Copy link

We are forking it too. There is a PR pending for this, ignored for long time. Is this project abandoned? Can someone take it over?

@gund
Copy link
Owner

gund commented Dec 1, 2021

Hi all!
Sorry for a delay but finally I'm back and will be able to update the peer deps soon!

@gund gund closed this as completed in fd6f953 Dec 1, 2021
@edbzn
Copy link

edbzn commented Dec 1, 2021

Hi @gund, great to see you alive. Would be great to migrate to ng 13 also.

gund pushed a commit that referenced this issue Dec 1, 2021
# [9.0.0](v8.0.1...v9.0.0) (2021-12-01)

### Bug Fixes

* **api:** remove deprecated APIs ([f7757de](f7757de))

### Features

* **ng:** update to Angular v12 ([fd6f953](fd6f953)), closes [#454](#454)

### BREAKING CHANGES

* **ng:** No API changes were introduced
* **api:** Removed APIs:
- Removed `ComponentInjector` - use `DynamicComponentInjector`
- Removed `COMPONENT_INJECTOR` - use `DynamicComponentInjectorToken`
@gund
Copy link
Owner

gund commented Dec 1, 2021

🎉 This issue has been resolved in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gund gund added the released label Dec 1, 2021
@gund
Copy link
Owner

gund commented Dec 1, 2021

Hey @edbzn, yes I will release updates in 2 steps - one for v12 and then for v13 =)

@gund
Copy link
Owner

gund commented Dec 1, 2021

Support for Angular v13 is out now as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants