Skip to content

Commit

Permalink
[iOS] support bundleUrl on eagle
Browse files Browse the repository at this point in the history
  • Loading branch information
jianhan-he committed Dec 13, 2018
1 parent 411ffeb commit 2046041
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ - (void)createInstance:(NSString *)instanceIdString
NSMutableArray *sendQueue = [NSMutableArray array];
[self.sendQueue setValue:sendQueue forKey:instanceIdString];

if (sdkInstance.dataRender && options) {
if (sdkInstance.dataRender && ![options[@"EXEC_JS"] boolValue]) {
WX_MONITOR_INSTANCE_PERF_START(WXFirstScreenJSFExecuteTime, [WXSDKManager instanceForID:instanceIdString]);
WX_MONITOR_INSTANCE_PERF_START(WXPTJSCreateInstance, [WXSDKManager instanceForID:instanceIdString]);

Expand Down
4 changes: 2 additions & 2 deletions ios/sdk/WeexSDK/Sources/Bridge/WXCoreBridge.mm
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ + (void)createDataRenderInstance:(NSString *)pageId template:(NSString *)jsBundl
if (!javascript) {
return;
}
[[WXSDKManager bridgeMgr] createInstanceForJS:pageId template:NSSTRING(javascript) options:nil data:data];
[[WXSDKManager bridgeMgr] createInstanceForJS:pageId template:NSSTRING(javascript) options:options data:data];
});
}

Expand All @@ -787,7 +787,7 @@ + (void)createDataRenderInstance:(NSString *)pageId contents:(NSData *)contents
if (!javascript) {
return;
}
[[WXSDKManager bridgeMgr] createInstanceForJS:pageId template:NSSTRING(javascript) options:nil data:data];
[[WXSDKManager bridgeMgr] createInstanceForJS:pageId template:NSSTRING(javascript) options:options data:data];
});
}

Expand Down
4 changes: 3 additions & 1 deletion ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,12 @@ - (void)createInstanceForJS:(NSString *)instance
data:(id)data {
if (!instance || !temp) return;
__weak typeof(self) weakSelf = self;
NSMutableDictionary *newOptions = [options mutableCopy] ?: [NSMutableDictionary new];
newOptions[@"EXEC_JS"] = @(YES);
WXPerformBlockOnBridgeThread(^(){
[weakSelf.bridgeCtx createInstance:instance
template:temp
options:options
options:newOptions
data:data];
});
}
Expand Down

0 comments on commit 2046041

Please sign in to comment.