-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] zio-http support #1615
[WIP] zio-http support #1615
Conversation
Understood about the dependency. I've added the That should help the CI get further. |
Hi @blast-hardcheese! The problem: the framework is too coupled and forces plugins to follow its ways. It defines generators interfaces and implements a common logic using them. The common logic prevents plugins to evolve independently, forces to them some common dependencies (for example cats and circe libraries) and complicates generating more "natural" for a particular plugin code. Suggested solution: get rid of the common logic. Of cause the OpenAPI parsing logic should stay shared, but plugins should become as independent as possible, ideally, they could become even a separate applications WDYT? |
This is what I was attempting to do with the modules and SPI; I agree with the difficulties you're experiencing, the explosion of build tooling requirements is concerning though. I will try to respond with a more thorough consideration within the next week, I've been pulling a lot of long nights recently. |
@zeal18 How do you want to proceed here, and do you still have interest in tending to this PR? Otherwise I can take a pass on getting the branch rebased, time permitting. Your choice. |
Hi @blast-hardcheese! yes, I'm still considering continuing working on this, but I have a lack of time at the moment. I'll try to keep it moving starting from rebasing |
@zeal18 if there's anything I can do to help please let me know. |
e91cfdd
to
f0f4fdb
Compare
f0f4fdb
to
6854ee4
Compare
So far I've defined the module, but it won't compile because it appeared that the zio-http is not published yet (local build requires building other dependencies locally as well and couldn't be verified in the CI). The plan is the following:
Issue: #1038