Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment security design test - remove variants 1 and 3 #2211

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

tjsilver
Copy link
Contributor

Why are you doing this?

Variants 1 and 3 are peforming the least well, so we are removing them from the test to allow the other variants to reach significance sooner.

Trello Card

Changes

  • Remove V1_securetop
  • Remove V3_securebottom

@tjsilver tjsilver requested review from tomrf1 and jlieb10 November 12, 2019 12:29
Copy link
Member

@tomrf1 tomrf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tjsilver tjsilver force-pushed the ts-payment-security-r1-amend2 branch from f290c98 to e88103b Compare November 12, 2019 14:06
@tjsilver tjsilver merged commit b0478f9 into master Nov 12, 2019
@tjsilver tjsilver deleted the ts-payment-security-r1-amend2 branch November 12, 2019 14:14
@prout-bot
Copy link

Seen on PROD (merged by @tjsilver 9 minutes and 53 seconds ago)

Sentry Release: support-client-side, support

@prout-bot
Copy link

✅ Testing in PROD passed! Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants