Payment security reassurance test #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjsilver
requested review from
tomrf1,
jlieb10,
ionamckendrick,
jesseyuen and
JoemG
jlieb10
reviewed
Oct 24, 2019
support-frontend/assets/components/secureTransactionIndicator/securePadlock.svg
Outdated
Show resolved
Hide resolved
jlieb10
reviewed
Oct 24, 2019
support-frontend/assets/pages/contributions-landing/components/PaymentMethodSelector.jsx
Show resolved
Hide resolved
jlieb10
reviewed
Oct 24, 2019
...ort-frontend/assets/pages/contributions-landing/components/StripeCardForm/StripeCardForm.jsx
Outdated
Show resolved
Hide resolved
jlieb10
reviewed
Oct 24, 2019
support-frontend/assets/pages/contributions-landing/contributionsLanding.jsx
Show resolved
Hide resolved
jlieb10
reviewed
Oct 24, 2019
| @@ -837,6 +842,17 @@ form { | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .form__submit--secure { | |||
| margin: -6px -10px 0; | |||
There was a problem hiding this comment.
could we achieve similar top and bottoms for margins and padding using $gu-v-spacing / 2 instead? For code and vis consistency?
There was a problem hiding this comment.
Maybe - I couldn't get $gu-v-spacing to work with negative values but maybe we can pair on this?
jlieb10
previously requested changes
Oct 24, 2019
ionamckendrick
approved these changes
Oct 24, 2019
tomrf1
reviewed
Oct 24, 2019
support-frontend/assets/components/secureTransactionIndicator/secureTransactionIndicator.jsx
Outdated
Show resolved
Hide resolved
tomrf1
reviewed
Oct 24, 2019
support-frontend/assets/pages/contributions-landing/components/ContributionForm.jsx
Outdated
Show resolved
Hide resolved
tomrf1
reviewed
Oct 24, 2019
support-frontend/assets/pages/contributions-landing/components/PaymentMethodSelector.jsx
Outdated
Show resolved
Hide resolved
tjsilver
force-pushed
the
ts-payment-security-design
branch
from
7b0af3c to
2b5de61
Compare
tjsilver
commented
Oct 25, 2019
|
Seen on PROD (merged by @tjsilver 11 minutes and 47 seconds ago)
Sentry Release: support-client-side, support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
We are testing the placement of a 'secure transaction' indicator to reassure users that their payment is secure.
Trello Card
Changes
Screenshots
Control - mobile
Control - desktop
V1_securetop - mobile
V1_securetop - desktop
V2_securemiddle - mobile
V2_securemiddle - desktop
V3_securebottom - Stripe Elements - mobile
V3_securebottom - Direct debit Monthly/Annual
V3_ securebottom - Stripe elements - desktop
V3_securebottom - Paypal single
V3_securebottom - Paypal Monthly/Annual
V4_grey - grey background on Stripe elements container - no secure transaction indicator