Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Add deprecation information #529

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Add deprecation information #529

merged 1 commit into from
Jan 30, 2019

Conversation

RichieAHB
Copy link
Contributor

Add the deprecation information to the README and link to Leaving Scribe. I will also prefix the GitHub description with DEPRECATED: once this is merged.

Any comments welcome 👍

@RichieAHB
Copy link
Contributor Author

Also I'm not sure what happened to html-janitor I think we recovered it after having deleted it but it's failing the build as we maybe didn't recover it to the version it was at before deletion (notable 2.0.4). I can either downgrade Scribe back to 2.0.2 but I feel like the patch versions in 2.0.4 probably fixed something worth fixing!

@mbarton
Copy link

mbarton commented Jan 30, 2019

@RichieAHB I published 2.0.4 a while back to fix some vulnerabilities: guardian/html-janitor#1

It shows as the latest version on npm (https://www.npmjs.com/package/html-janitor). It was 2.0.2 before deletion from memory, with 2.0.4 being my version I released after deleting the repo.

@RichieAHB
Copy link
Contributor Author

@mbarton ah interesting - the package.json shows as 2.0.4 so it's probably just that some tags got deleted - happy to push 2.0.4 to master.

@mbarton
Copy link

mbarton commented Jan 30, 2019

Sounds good. Also ewwww github dependencies

@RichieAHB RichieAHB merged commit 9668e01 into master Jan 30, 2019
@jukecraft jukecraft deleted the rahb/deprecation branch January 30, 2019 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants