This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Fix Scribe adding links to other contenteditables #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichieAHB
commented
Aug 9, 2018
| @@ -101,35 +101,36 @@ define(function () { | |||
| nodeHelpers.getAncestor(node, scribe.el, nodeFilter); | |||
| }; | |||
|
|
|||
| Selection.prototype.placeMarkers = function () { | |||
| Selection.prototype.isInScribe = function () { | |||
There was a problem hiding this comment.
The diff doesn't really show this nicely but placeMarkers still exists but it has functionality to check whether the selection was in Scribe that I broke out into a method that could be used in create-link.
mbarton
approved these changes
Aug 10, 2018
RichieAHB
added a commit
that referenced
this pull request
Aug 10, 2018
Fix Scribe adding links to other contenteditables
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops Scribe throwing it's links around into other contenteditable nodes. This probably could be widened to ignore any commands when Scribe doesn't have a selection or focus, but the surface area of this PR would increase by a factor of 100 and I have no idea what it might break.
Recommend reading this diff in split view!