This repository has been archived by the owner on Jun 15, 2021. It is now read-only.
Do not insert <br> into custom elements
#501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have an example live or in public repository, but the project I'm working on will be 100% open source eventually (hopefully soon). Maintaining forks is pretty difficult from my experience, so I'm submitting upstream all of the patches needed so far to make Scribe compatible with custom elements (including Shadow DOM). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only found tests for formatter in
test-oldbut don't know how to run them (they are not running withnpm test) so no tests this time.I've started using Scribe with Shadow DOM and custom elements, so expect more PRs in future if there will be any issues:)