Redux: Handle organisation level ping webhooks #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
force-pushed
the
rt/organisation-webhook
branch
3 times, most recently
from
a26d049 to
1d45166
Compare
When set up at the organisation level the initial "ping" webhook GitHub sends to test the connection is missing the "repository" key. We crashed on that before meaning the webhook was never enabled:
java.lang.NullPointerException: null
at scala.collection.StringOps$.split$extension(StringOps.scala:836)
at com.madgag.scalagithub.ResponseMeta$.requestScopesFrom(GitHub.scala:90)
at com.madgag.scalagithub.ResponseMeta$.from(GitHub.scala:100)
at com.madgag.scalagithub.GitHub$.logAndGetMeta(GitHub.scala:126)
at com.madgag.scalagithub.GitHub.$anonfun$executeAndWrap$1(GitHub.scala:392) at com.madgag.okhttpscala.package$RickOkHttpClient$$anon$1.$anonfun$onResponse$1(package.scala:45)
at scala.util.Try$.apply(Try.scala:217)
at com.madgag.okhttpscala.package$RickOkHttpClient$$anon$1.onResponse(package.scala:45)
at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
Submitting a test message with curl:
```
curl \
-H 'X-GitHub-Event: ping' \
-H 'X-GitHub-Delivery: mtest' \
-H 'Content-Type: application/json' \
-d @"/Users/Roberto_Tyley/Library/Application Support/JetBrains/IntelliJIdea2024.3/scratches/scratch_262.json" \
-v \
http://localhost:9000/api/hooks/github
* Host localhost:9000 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
* Trying [::1]:9000...
* Connected to localhost (::1) port 9000
> POST /api/hooks/github HTTP/1.1
> Host: localhost:9000
> User-Agent: curl/8.7.1
> Accept: */*
> X-GitHub-Event: ping
> X-GitHub-Delivery: mtest
> Content-Type: application/json
> Content-Length: 2382
>
* upload completely sent off: 2382 bytes
< HTTP/1.1 200 OK
< Referrer-Policy: origin-when-cross-origin, strict-origin-when-cross-origin
< X-Frame-Options: DENY
< X-XSS-Protection: 1; mode=block
< X-Content-Type-Options: nosniff
< X-Permitted-Cross-Domain-Policies: master-only
< Date: Wed, 22 Jan 2025 17:51:56 GMT
< Content-Type: text/plain; charset=UTF-8
< Content-Length: 4
<
* Connection #0 to host localhost left intact
pong
```
Logged:
[info] c.Api in application-pekko.actor.default-dispatcher-9 - githubHook event=ping repo=None githubDeliveryGuid=Some(mtest) xRequestId=None
rtyley
force-pushed
the
rt/organisation-webhook
branch
from
1d45166 to
d99dd2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight refactor of #122 - the diff is a bit smaller, because it doesn't inline
Parsers.scala:The original PR description is excellent:
I've verified that this updated PR still handles organisation level pings, using the curl described in the original PR.