Fix regression for checking validity of login (master) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately a regression was introduced which means that sessions are not automatically re-validated when the session expires (according to the expiry time provided by Google). This fixes that and also provides the `login_hint` e-mail address to avoid the account chooser on re-auth. Note that this might break applications with AJAX endpoints as calls within JS will not follow the redirect correctly. The workflow project has a way around this - speak to @steppenwells if interested. Alternatively you can relax the requirement to re-authenticate by setting the `enforceValidity` parameter in your `GoogleAuthConfig` to `false`.
sihil
changed the title
|
Is it feasible to add a test to stop me breaking this again? Otherwise 👍 |
|
I was wondering about that when I was writing it. I'll add an issue to look at adding some tests. |
sihil
added a commit
that referenced
this pull request
Oct 15, 2014
Fix regression for checking validity of login (master)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make changes from #17 in master branch
Unfortunately a regression was introduced which means that sessions are not automatically re-validated when the session expires (according to the expiry time provided by Google). This fixes that and also provides the
login_hinte-mail address to avoid the account chooser on re-auth.Note that this might break applications with AJAX endpoints as calls within JS will not follow the redirect correctly. The workflow project has a way around this - speak to @steppenwells if interested. Alternatively you can relax the requirement to re-authenticate by setting the
enforceValidityparameter in yourGoogleAuthConfigtofalse.