Change some packages including Webpack, Jest and Babel to sort vulnerabilities #338
+3,673
−6,763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on vulnerable cross-spawn version
rhystmills
force-pushed
the
rm/sort-vulns
branch
3 times, most recently
from
d2b04ad to
71ddd74
Compare
rhystmills
force-pushed
the
rm/sort-vulns
branch
from
71ddd74 to
2969283
Compare
…onger included in jest
…ract a breaking change introducing new default behaviour in snapshots, by adding new configuration that preserves the existing snapshot handling
rhystmills
force-pushed
the
rm/sort-vulns
branch
from
221b0a4 to
8d68c35
Compare
rhystmills
force-pushed
the
rm/sort-vulns
branch
from
8d68c35 to
a2e33c3
Compare
rhystmills
changed the title
rhystmills
changed the title
|
Seen on PROD (merged by @rhystmills 3 minutes and 16 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR changes a few packages to try and sort some high priority vulnerabilities in the application (mostly in dev dependencies).
It builds on some work done by Rik which saw some failing tests after he bumped Jest.
Specifically, this PR:
jestand related packages, in the shared dependencieswebpackand related dependencies in theclientsub-project to stop using a vulnerable version ofhttp-proxy-middleware@babel/coreand related dependencies in theclientsub-project to rely on a vulnerable version ofcross-spawnin fewer placesyarn-run-alltonpm-run-alldue to a vulnerability in the former, which is irregularly updated (last published 8 years ago)This seemed like a decent amount to cover in one PR. There is a remaining vulnerability in
wsrun, last updated 4 years ago, which I decided not to tackle in this PR, and probably more elsewhere in the project.I had to make two changes to the jest config because of breaking changes in jest:
uuidpackage that was required byaws-sdk, thread about that here: ESM Problems with Jest@26 and Node.js 14.x uuidjs/uuid#451 (comment)How to test
yarn testin the root. Do they all pass?I'm happy to pair if you have any trouble running either.