Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize gocloud and blob store to work around pubsub message size #1630

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Jan 9, 2024

Description of the PR

Address the sizing issue for NATS in issue #731

The key is the hash of the SBOM such that it can be retrieved later if needed based on hasSBOM data.

Tested via S3 and works by reading and writing to the bucket.
Note: currently it does not delete items from the bucket.

For local testing:

Filesystem can be used as documented here: https://gocloud.dev/howto/blob/#local

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Copy link
Member

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, some nits

container_files/guac/guac.yaml Show resolved Hide resolved
pkg/blob/blob.go Outdated Show resolved Hide resolved
pkg/handler/processor/process/process.go Outdated Show resolved Hide resolved
pkg/events/events.go Outdated Show resolved Hide resolved
pkg/handler/collector/collector.go Outdated Show resolved Hide resolved
cmd/README.md Show resolved Hide resolved
pkg/handler/collector/collector.go Outdated Show resolved Hide resolved
pkg/events/events.go Show resolved Hide resolved
pkg/handler/collector/collector_test.go Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit db84270 into guacsec:main Jan 22, 2024
8 checks passed
@pxp928 pxp928 deleted the poc-go-cloud branch January 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants