Return gtmPlugin from app context

[filiphazardous]

I have a problem with Vite inline, which in production mode just copies the useGtm function wholesale to the calling file, without copying the scope. This fix solves that problem, since it always fetches the gtm instance from the vue app context

[filiphazardous]

Here's the bug in nuxt-gtm that this would solve (at least in my use-case): zadigetvoltaire/nuxt-gtm#14

[Shinigami92]

Looks like getCurrentInstance is there since Vue v3.0.0. So I guess this is safe.

vuejs/core@9c0f820

[Shinigami92]

Is it possible to add a test for this? So we can prevent regression?

[filiphazardous]

Is it possible to add a test for this? So we can prevent regression?

I'll see if I can come up with a way to test it. What triggered it in our case was two levels of indirection (it was initialized through nuxt-gtm and useGtm was called directly in our project, so I guess Vite couldn't connect the dots). I'll see if I can reproduce a similar sandbox.

[Shinigami92]

Is it possible to add a test for this? So we can prevent regression?

I'll see if I can come up with a way to test it. What triggered it in our case was two levels of indirection (it was initialized through nuxt-gtm and useGtm was called directly in our project, so I guess Vite couldn't connect the dots). I'll see if I can reproduce a similar sandbox.

Maybe spy or mocks can help to simplify it