Skip to content
This repository has been archived by the owner on Dec 29, 2024. It is now read-only.

feat: allows users specifying a message when saving #32

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

gsilvapt
Copy link
Owner

Closes #31.

@AugustasV not sure how comfortable you are with testing this but this is the feature you requested. If you are unable to test it, I can merge this and we can test using the resulting binary.

Thanks a lot for your contribution.

@gsilvapt gsilvapt force-pushed the feat/save-message branch 2 times, most recently from 7fa67ea to bfa0122 Compare January 19, 2022 23:33
@AugustasV
Copy link
Contributor

I was using terratest for some projects, but not sure about that

@gsilvapt
Copy link
Owner Author

gsilvapt commented Jan 21, 2022

Seems a bit overkill for this.

I need to read more on how to release and install alpha/beta releases - sorry. For the time being, to try this build you would have to pull from this branch, run go build -o bin/pmz and run the commands with this binary bin/pmz ....

In case you are uncomfortable with this, I can prioritise what I mentioned first in this comment, so we can try having stable and alpha releases.

Thanks

@AugustasV
Copy link
Contributor

AugustasV commented Jan 21, 2022

Hi @gsilvapt Tried to do that, I run command without anything I get that

augustasv@augustasv-ProBook:~/Documents/zet$ ~/Documents/pmz/bin/pmz 
panic: "message" shorthand is more than one ASCII character

goroutine 1 [running]:
github.com/spf13/pflag.(*FlagSet).AddFlag(0xc00013e500, 0xc0001b8e60)
        /home/augustasv/go/pkg/mod/github.com/spf13/[email protected]/flag.go:864 +0x4bf
github.com/spf13/pflag.(*FlagSet).VarPF(0xdfc800, {0xa7a780, 0xc0001b0ac0}, {0x9b39c6, 0x1}, {0x9b515e, 0x7}, {0x9d29cc, 0x3d})
        /home/augustasv/go/pkg/mod/github.com/spf13/[email protected]/flag.go:831 +0x151
github.com/spf13/pflag.(*FlagSet).VarP(...)
        /home/augustasv/go/pkg/mod/github.com/spf13/[email protected]/flag.go:837
github.com/spf13/pflag.(*FlagSet).StringVarP(0x1, 0xc00013e200, {0x9b39c6, 0xc00013e200}, {0x9b515e, 0xc00013e200}, {0x9c0689, 0x9e9508}, {0x9d29cc, 0x3d})
        /home/augustasv/go/pkg/mod/github.com/spf13/[email protected]/string.go:42 +0x6e
github.com/spf13/pflag.(*FlagSet).StringP(...)
        /home/augustasv/go/pkg/mod/github.com/spf13/[email protected]/string.go:67
github.com/gsilvapt/pmz/cmd.init.2()
        /home/augustasv/Documents/pmz/cmd/save.go:86 +0xa

Actually I can't run any command, all the time getting this error. Issue with a branch because when I switched to main branch, built again, everything worked smooth.

@gsilvapt
Copy link
Owner Author

Sorry for that. Fixed it and it worked now. Tested locally. Going to merge the changes and you can install the latest version.
Thanks!

@gsilvapt gsilvapt merged commit 3535c49 into main Jan 22, 2022
@gsilvapt gsilvapt deleted the feat/save-message branch January 22, 2022 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Allow different commit message
2 participants