Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

Import results in few errors #11

Closed
Fak3 opened this issue Jan 13, 2020 · 4 comments
Closed

Import results in few errors #11

Fak3 opened this issue Jan 13, 2020 · 4 comments

Comments

@Fak3
Copy link

Fak3 commented Jan 13, 2020

When i export the interchange json for this file, then i create new empty staruml file and import the interchange file back, i am getting quite a few errors like this:
Screenshot_20200114_010005

Why am I getting these errors when i import, but did not see any errors when i performed an export earlier? I think It should give the errors\warnings when i export, if there are any such errors which won't allow me to correctly import this file afterwards.

Then when i try to drag TransportMovement to the diagram, it does not get added, but some other entities like Voyage can be added by dragging it to the canvas.

@faizanvahevaria
Copy link
Contributor

faizanvahevaria commented Jan 27, 2020

download

Hello @Fak3
In the screenshot, I had discussed with @onthebreeze.
So its a RULE If we use any class from other package ( For example : 'TransportParty' class is inherited from 'Party' package from this file. So, Those classes should be abstract as indicated in scheenshot.
So, I made 'isAbstract' property 'true' of 'TransportParty' class in 'Party' package.
Please follow this rule. Then export and import.

One more thing, model interchange extension will not export diagram. So, when you will follow above instruction and import it in new file, only classes and packages will be imported.

@Fak3
Copy link
Author

Fak3 commented Jan 27, 2020

So, I made 'isAbstract' property 'true' of 'TransportParty' class in 'Party' package. Please follow this rule. Then export and import.

Ok, i just did that. Now i don't get the errors when i import the file.

But two issues still persist:

  1. If a class is missing isAbstract property, we should generate a warning when the user exports the interchange file, but not when it imports.

  2. I am still unable to add TransportMovements to the diagram - when i drag and drop it to the canvas nothing happens.

@faizanvahevaria
Copy link
Contributor

@Fak3
Please close this ticket if this is fine

@Fak3
Copy link
Author

Fak3 commented Feb 8, 2020

fixed

@Fak3 Fak3 closed this as completed Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants