Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of empty feature blocks #3580

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Add handling of empty feature blocks #3580

merged 4 commits into from
Nov 19, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Nov 19, 2024

Description

Add handling of empty feature blocks:

  • added error when default value is not set
  • added test to track this behaviour

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256 denis256 marked this pull request as ready for review November 19, 2024 14:32
Copy link
Collaborator

@yhakbar yhakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but we should in the docs that feature flags must have default values:
https://terragrunt.gruntwork.io/docs/reference/config-blocks-and-attributes/#feature

@denis256 denis256 merged commit 533bc11 into main Nov 19, 2024
4 of 5 checks passed
@denis256 denis256 deleted the empty-flag-block branch November 19, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants