-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support discovery of symlinked modules #3562
Conversation
|
7875350
to
852f415
Compare
Thanks for the input @denis256, there was a minor issue in the func, regarding to circular links, that was producing different results on MacOS and Linux. It is now fixed and the lint strict issues were also addressed. Could you please run the tests again? |
9268d37
to
c9f79ea
Compare
Minor spelling issue that we can ignore, but tests are passing.
I'll let @denis256 decide if we should approve and merge. |
🕵️ |
Signed-off-by: Rodrigo Fior Kuntzer <[email protected]>
c9f79ea
to
8f89e67
Compare
@denis256, spelling issue fixed, both ![]() |
Thanks, @rodrigorfk . We're testing some edge cases to make sure that nothing is awry before merging. |
Description
Fixes #1611.
This PR continues the work that was started by @aslafy-z in the staled #3101 PR as following:
WalkWithSymlinks
function to theutil
package, here is the reason for having it's own implementation in the Terragrunt codebase:edwardrf/symwalk
on the original implementation was working only because the usage ofhelpers.CopyEnvironment
in the tests, was resolving copying and symlinks statically, and not really preserving it on the temporary env path, which defeats the purpose of test and does not mimic what terragrunt will be doing when running targeting a real directory with symlinks directly into it, this issue was addressed in my tests and a comment regarding to it was left in the codebase..terragrunt-cache
invalidation, which was one of the concerns added by @denis256 feat: support discovery of symlinked modules #3101 (comment)TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added support for discovery of symlinked modules